[SWIP-33] Upgrade StakeWise Boost Strategy After Changes In Aave Contracts

Executive summary

This proposal seeks to edit the StakeWise Boost strategy contract to account for the recent changes in the approach to rounding within the Aave DAO smart contracts.

Should this proposal pass, users that currently have an open Boost position will have an additional transaction included in the unboost transaction bundle.

Motivation

Recent changes in the Aave source code have prompted occassional failures of claim transactions for users trying to collect funds after unboosting from Vaults.

Specifically, Aave is now rounding values up rather than down, while the StakeWise Boost strategy is still rounding values down. In some instances, this leads to a shortfall of 1 wei in the amount of assets being returned to Aave during the claiming of unboosted assets, which results in the claim transaction being reverted.

Naturally, this is bad UX, and causes misunderstanding and stress among the users of Boost.

This proposal introduces the necessary fix to the StakeWise Boost Strategy, accounting for the new approach to rounding in the Aave smart contracts. It’s simple - the strategy will also begin rounding values up rather than down, avoiding situations where a shortfall occurs and a claim transaction fails.

There are no actions for the Boost users to take right now. However, should this proposal pass, Boost users will have an additional transaction to upgrade their strategy contract included in the unboost request transaction bundle.

Specification

The json for the proposed change can be found below:

strategyUpgrade.json

[
{
“to”: “0x90b82E4b3aa385B4A02B7EBc1892a4BeD6B5c465”,
“operation”: “0”,
“value”: “0.0”,
“data”: “0xbaa82a340000000000000000000000007575bc9e5168f27b97f9028905a2adf91d2ff53d0000000000000000000000000000000000000000000000000000000000000001”,
“method”: “setStrategy(address,bool)”,
“params”: [
“0x7575BC9E5168f27B97F9028905A2Adf91d2fF53d”,
“true”
]
},
{
“to”: “0x90b82E4b3aa385B4A02B7EBc1892a4BeD6B5c465”,
“operation”: “0”,
“value”: “0.0”,
“data”: “0x0869ddd38b74cefe9f33d72ccd3521e6d331272921607e547c75c914c2c56cfdad9defed000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000009757067726164655631000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000000000000000007575bc9e5168f27b97f9028905a2adf91d2ff53d”,
“method”: “setStrategyConfig(bytes32,string,bytes)”,
“params”: [
“0x8b74cefe9f33d72ccd3521e6d331272921607e547c75c914c2c56cfdad9defed”,
“upgradeV1”,
“0x0000000000000000000000007575bc9e5168f27b97f9028905a2adf91d2ff53d”
]
}
]

Considerations

This is a cosmetic change to the underlying Boost contract that is not expected to introduce any behaviour changes. Nevertheless, out of abundance of caution, the changes in the contract have been audited by Hexens, the authors of the original StakeWise Boost audit. You can review the audit results here.

Discussion

Should you have any comments or questions regarding this proposal, please leave them below.

Vote

The Snapshot for this SWIP is now live: Snapshot

1 Like